Skip to content

fix(@angular/cli): provide actionable error when project cannot be determined #23302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

alan-agius4
Copy link
Collaborator

When the workspace has multiple projects and we the project to use cannot be determined from the current working directory, we now issue an actionable error message.

Closes #23291

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 7, 2022
@alan-agius4 alan-agius4 force-pushed the error-cannot-determine-project-cli branch from 80ac6fc to 8ac7f57 Compare June 7, 2022 10:56
@alan-agius4 alan-agius4 requested a review from clydin June 7, 2022 11:35
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 7, 2022
@alan-agius4 alan-agius4 marked this pull request as draft June 7, 2022 12:09
@alan-agius4 alan-agius4 closed this Jun 7, 2022
@alan-agius4 alan-agius4 force-pushed the error-cannot-determine-project-cli branch from 8ac7f57 to f6f3782 Compare June 7, 2022 12:20
@alan-agius4 alan-agius4 reopened this Jun 7, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review June 7, 2022 12:23
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 7, 2022
@alan-agius4 alan-agius4 force-pushed the error-cannot-determine-project-cli branch 6 times, most recently from c9a2d4e to 077ee8f Compare June 7, 2022 16:08
…termined

When the workspace has multiple projects and we the project to use cannot be determined from the current working directory, we now issue an actionable error message.
@alan-agius4 alan-agius4 force-pushed the error-cannot-determine-project-cli branch 2 times, most recently from 35a7033 to 19c3ec0 Compare June 8, 2022 08:04
Yargs allows passing using positional arguments as flags. This we should handle this when retrieving the project.

Closes angular#23291
@alan-agius4 alan-agius4 force-pushed the error-cannot-determine-project-cli branch from 19c3ec0 to b14a187 Compare June 8, 2022 08:10
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 8, 2022
@clydin clydin merged commit f6e8ce2 into angular:main Jun 8, 2022
@alan-agius4 alan-agius4 deleted the error-cannot-determine-project-cli branch June 8, 2022 14:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build --watch does not work after adding a lib to the workspace
2 participants